| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20101028.101618.226776102.davem@davemloft.net> Date: Thu, 28 Oct 2010 10:16:18 -0700 (PDT) From: David Miller <davem@...emloft.net> To: rostedt@...dmis.org Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, error27@...il.com, masa-korg@....okisemi.com, akpm@...ux-foundation.org Subject: Re: [PATCH] Fix missing dependency of PCH_GBE driver From: Steven Rostedt <rostedt@...dmis.org> Date: Thu, 28 Oct 2010 08:16:29 -0400 > While doing some randconfigs I stumbled across this build error: > > ERROR: "mii_ethtool_gset" [drivers/net/pch_gbe/pch_gbe.ko] undefined! > ERROR: "generic_mii_ioctl" [drivers/net/pch_gbe/pch_gbe.ko] undefined! > ERROR: "mii_nway_restart" [drivers/net/pch_gbe/pch_gbe.ko] undefined! > ERROR: "mii_check_gmii_support" [drivers/net/pch_gbe/pch_gbe.ko] undefined! > ERROR: "mii_link_ok" [drivers/net/pch_gbe/pch_gbe.ko] undefined! > ERROR: "mii_ethtool_sset" [drivers/net/pch_gbe/pch_gbe.ko] undefined! > > The config option PCH_GBE is missing the dependency of MII. > > Signed-off-by: Steven Rostedt <rostedt@...dmis.org> The canonical way to handle this is to use 'select'. Thus, I've committed the following to fix this. Thanks. -------------------- pch_gbe: Select MII. Reported-by: Steven Rostedt <rostedt@...dmis.org> Signed-off-by: David S. Miller <davem@...emloft.net> --- drivers/net/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 77c1fab..f24179d 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2520,6 +2520,7 @@ source "drivers/net/stmmac/Kconfig" config PCH_GBE tristate "PCH Gigabit Ethernet" depends on PCI + select MII ---help--- This is a gigabit ethernet driver for Topcliff PCH. Topcliff PCH is the platform controller hub that is used in Intel's -- 1.7.3.2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists