netdev - Re: [PATCH] pktgen: Limit how much data we copy onto the stack.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101028.113237.193691913.davem@davemloft.net>
Date:	Thu, 28 Oct 2010 11:32:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nelhage@...lice.com
Cc:	eric.dumazet@...il.com, robert.olsson@....uu.se,
	andy.shevchenko@...il.com, netdev@...r.kernel.org,
	eugene@...hat.com
Subject: Re: [PATCH] pktgen: Limit how much data we copy onto the stack.

From: Nelson Elhage <nelhage@...lice.com>
Date: Thu, 28 Oct 2010 11:20:42 -0400

> A program that accidentally writes too much data to the pktgen file can overflow
> the kernel stack and oops the machine. This is only triggerable by root, so
> there's no security issue, but it's still an unfortunate bug.
> 
> printk() won't print more than 1024 bytes in a single call, anyways, so let's
> just never copy more than that much data. We're on a fairly shallow stack, so
> that should be safe even with CONFIG_4KSTACKS.
> 
> Signed-off-by: Nelson Elhage <nelhage@...lice.com>

Applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html