netdev - Re: [PATCH] decnet: RCU conversion and get rid of dev_base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288360479.9016.35.camel@dolmen>
Date:	Fri, 29 Oct 2010 14:54:39 +0100
From:	Steven Whitehouse <steve@...gwyn.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] decnet: RCU conversion and get rid of dev_base_lock

Hi,

On Fri, 2010-10-29 at 15:09 +0200, Eric Dumazet wrote:
> While tracking dev_base_lock users, I found decnet used it in
> dnet_select_source(), but for a wrong purpose:
> 
> Writers only hold RTNL, not dev_base_lock, so readers must use RCU if
> they cannot use RTNL.
> 
> Adds an rcu_head in struct dn_ifaddr and handle proper RCU management.
> 
> Adds __rcu annotation in dn_route as well.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

I've not tested this, but I've read through it all and it seems good to
me.

Acked-by: Steven Whitehouse <swhiteho@...hat.com>

Steve.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html