netdev - Re: [PATCH 0/15] RFC: create drivers/net/legacy for ISA, EISA, MCA drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Oct 2010 17:01:59 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 0/15] RFC: create drivers/net/legacy for ISA, EISA, MCA
 drivers

On Fri, 2010-10-29 at 15:08 -0700, Joe Perches wrote:
> On Fri, 2010-10-29 at 17:26 -0400, Paul Gortmaker wrote:
> > On 10-10-28 09:48 PM, Joe Perches wrote:
> > > On Thu, 2010-10-28 at 21:19 -0400, Paul Gortmaker wrote:
> > >> The drivers/net dir has a lot of files - originally there were
> > >> no subdirs, but at least now subdirs are being used effectively.
> > >> But the original drivers from 10+ years ago are still right
> > >> there at the top.  This series creates a drivers/net/legacy dir.
> > > I like this idea.
> > > I suggest a bit of a further grouping by using a
> > > drivers/net/ethernet directory and putting those
> > > legacy drivers in a new subdirectory
> > > drivers/net/ethernet/legacy.
> > That is a substantially larger change, since you'd now be
> > relocating nearly every remaining driver, i.e. all the
> > relatively modern 100M and GigE drivers.
> 

I am not particularly a fan of making a "legacy" directory and moving
old drivers into it.  Just because this is very subjective, if you say
"drivers which are X years old and not used much" is vague and depending
on who you ask would get varying results.  But if you were to were to
define legacy as all ISA, EISA and MCA drivers (not based on their use)
would be better.

But if a legacy directory was to be made, I like Joe's suggestion of
drivers/net/ethernet/legacy.

> Files to not need immediate renames.
> 
> Renames could happen when the appropriate maintainer
> wants to or gets coerced to conform to some new
> file layout standard.
> 
> I had submitted a related RFC patch:
> 
> https://patchwork.kernel.org/patch/244641/
> 
> and then had some off list discussions
> with Jeff Kirsher from Intel.
> 
> Perhaps Jeff will chime in.
> 
> > Plus what do you
> > do with the sb1000 - create drivers/cablemodem/legacy
> > just for one file?
> 
> I never looked at that particular driver before.
> Maybe.  I don't have a strong opinion.  Leaving
> it where it is might be OK.
> 
> > Or the ethernet drivers already in
> > existing subdirs, like arm and pcmcia -- do we move those?
> 
> Maybe.  If there's no demand, there's no absolute need to
> move it at all.  I think a reasonable goal is to have some
> sensible and consistent file layout scheme though.
> 
> There are arch specific directories under various drivers/...
> so I don't see a need to move directories like drivers/net/arm
> or drivers/s390.

I agree with Joe.

> 
> > With this, I tried to aim for a significant gain (close to 1/3
> > less files) within what I felt was a reasonable sized change
> > set that had a chance of getting an overall OK from folks.
> > Giant "flag-day" type mammoth changesets are a PITA for all.
> 
> I believe there's no need for a flag-day.
> File renames could happen gradually or not at all.
> 
> 

Again I agree with Joe.


Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)