netdev - Re: [PATCH] usbnet: fix usb_autopm_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101101.080825.193699846.davem@davemloft.net>
Date:	Mon, 01 Nov 2010 08:08:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	andy.shevchenko@...il.com
Cc:	tom.leiming@...il.com, netdev@...r.kernel.org, oliver@...kum.org,
	dbrownell@...rs.sourceforge.net, gregkh@...e.de,
	ben@...adent.org.uk, joe@...ches.com, stable@...nel.org
Subject: Re: [PATCH] usbnet: fix usb_autopm_get_interface failure(v1)

From: Andy Shevchenko <andy.shevchenko@...il.com>
Date: Mon, 1 Nov 2010 17:04:35 +0200

>> +       /*usbnet already took usb runtime pm, so have to enable the feature
>> +       * for usb interface, otherwise usb_autopm_get_interface may return
>> +       * failure if USB_SUSPEND(RUNTIME_PM) is enabled.
>> +       * */
> Just minor: multiline comments doesn't follow the required style.

There were also spaces before tabs at the beginning of each
line.

I fixed all of this up when applying the patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html