netdev - Re: [PATCH] net: check queue_index from sock is valid for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101101.125605.28797776.davem@davemloft.net>
Date:	Mon, 01 Nov 2010 12:56:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: check queue_index from sock is valid for device

From: Tom Herbert <therbert@...gle.com>
Date: Mon, 1 Nov 2010 12:53:32 -0700 (PDT)

> In dev_pick_tx recompute the queue index if the value stored in the
> socket is greater than or equal to the number of real queues for the
> device.  The saved index in the sock structure is not guaranteed to
> be appropriate for the egress device (this could happen on a route
> change or in presence of tunnelling).  The result of the queue index
> being bad would be to return a bogus queue (crash could prersumably
> follow).
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>

Looks good, applied, thanks Tom.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html