netdev - Re: [PATCH] cxgb4vf: fix crash due to manipulating queues before registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CCF2B00.3060602@chelsio.com>
Date:	Mon, 01 Nov 2010 14:02:56 -0700
From:	Divy Le Ray <divy@...lsio.com>
To:	David Miller <davem@...emloft.net>
CC:	dm@...lsio.com, leedom@...lsio.com, netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb4vf: fix crash due to manipulating queues before
 registration

On 10/29/2010 01:05 PM, David Miller wrote:
> From: "Dimitrios Michailidis"<dm@...lsio.com>
> Date: Fri, 29 Oct 2010 00:36:22 -0700
>
>> Further, I believe moving the call after register_netdev is buggy as
>> open can be called after registration and it can clash with the
>> queue stopping.  It seems then that these netif_tx_stop_all_queues
>> calls have to go now.
> This is a good explanation of why no driver should be touching the
> queue state before the first ->open() call.

I'm sending a series of 3 patches fixing cxgb3, cxgb4, cxgb4vf.

Cheers,
Divy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html