netdev - Re: [patch] netlink: use TID instead of PID for automatic id assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1011010925400.16087@obet.zrqbmnf.qr>
Date:	Mon, 1 Nov 2010 09:27:39 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [patch] netlink: use TID instead of PID for automatic id
 assignment


On Monday 2010-11-01 03:25, Herbert Xu wrote:
>> 
>> netlink: use TID instead of PID for automatic id assignment
>> 
>> This makes it easier to identify processes in the output of `ss -af
>> netlink` - as I see no reason to force negative space numbers upon
>> all but the first socket in a thread group.
>> 
>> Turns out this reverts v2.6.15-rc4~65.
>> 
>> Cc: Herbert Xu <herbert@...dor.apana.org.au>
>> Signed-off-by: Jan Engelhardt <jengelh@...ozas.de>
>
>Nack.  Sockets are typically shared amongst threads so using the
>ID of the thread that created it doesn't make much sense when
>all the threads in that group use it to send/receive messages.

That would be fine, because they are in the same process.

>In any case, this field should not be relied on (please google
>the thread "netlink nlmsg_pid supposed to be pid or tid?") as
>anybody can claim your PID in the netlink name space.

I am aware of that. But then it raises the question why we are
giving the first socket a non-negative value in the first place.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html