netdev - Re: panic with 2.6.37-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288822281.2718.30.camel@edumazet-laptop>
Date:	Wed, 03 Nov 2010 23:11:21 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Gundersen <teg@...m.no>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: panic with 2.6.37-rc1

Le mercredi 03 novembre 2010 à 23:02 +0100, Tom Gundersen a écrit :
> I get panic during boot both with 2.6.37-rc1 and with current head.
> 
> Here is the error message:
> <http://www.lix.polytechnique.fr/~tom/2.6.37-rc1-panic.jpg>. My
> .config is below.
> 
> Let me know if you want more info. If you want I can test patches or
> bisect (if no one has any better suggestions).
> 

Please test following patch, thanks

[PATCH] atl1 : fix panic on load

Its now illegal to call netif_stop_queue() before register_netdev()

Reported-by: Tom Gundersen <teg@...m.no>
Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
---
 drivers/net/atlx/atl1.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
index 43579b3..5336310 100644
--- a/drivers/net/atlx/atl1.c
+++ b/drivers/net/atlx/atl1.c
@@ -3043,7 +3043,6 @@ static int __devinit atl1_probe(struct pci_dev *pdev,
 	atl1_pcie_patch(adapter);
 	/* assume we have no link for now */
 	netif_carrier_off(netdev);
-	netif_stop_queue(netdev);
 
 	setup_timer(&adapter->phy_config_timer, atl1_phy_config,
 		    (unsigned long)adapter);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html