netdev - Re: [PATCH 2/2] inet_diag: Make sure we actually run the same bytecode we audited.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101104132802.GA2904@canuck.infradead.org>
Date:	Thu, 4 Nov 2010 09:28:02 -0400
From:	Thomas Graf <tgraf@...radead.org>
To:	Nelson Elhage <nelhage@...lice.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] inet_diag: Make sure we actually run the same
 bytecode we audited.

On Wed, Nov 03, 2010 at 10:35:41PM -0400, Nelson Elhage wrote:
> We were using nlmsg_find_attr() to look up the bytecode by attribute when
> auditing, but then just using the first attribute when actually running
> bytecode. So, if we received a message with two attribute elements, where only
> the second had type INET_DIAG_REQ_BYTECODE, we would validate and run different
> bytecode strings.
> 
> Fix this by consistently using nlmsg_find_attr everywhere.
> 
> Signed-off-by: Nelson Elhage <nelhage@...lice.com>

Both patches look good.

Signed-off-by: Thomas Graf <tgraf@...radead.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html