netdev - netlink_carrier_on() race condition?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin4VvU9vXKT=5mmJFYN==YB5QfjOMo2cHQ0b5bJ@mail.gmail.com>
Date:	Thu, 4 Nov 2010 21:43:11 +0200
From:	Eliad Peller <eliad@...ery.com>
To:	netdev@...r.kernel.org
Subject: netlink_carrier_on() race condition?

hi,

i might be missing something, but i think there is some race condition
in netlink_carrier_on():
when calling it, it clears the __LINK_STATE_NOCARRIER flag and
enqueues a work to do everything needed.
this cause a period, in which  __LINK_STATE_NOCARRIER is unset (which
implies IFF_LOWER_UP), but the default qdiscs are not attached yet
(since the work hasn't been executed yet).
userspace might get some netlink events (e.g. wireless wext) in which
the IFF_LOWER_UP flag is set, but the queues are not ready.

shouldn't we clear the flag only after all the work is done?

thanks,
Eliad.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html