| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Nov 2010 18:35:27 -0200 From: Flavio Leitner <fleitner@...hat.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, herbert@...dor.hengli.com.au Subject: Re: [PATCH] net: reset gso header when the copied skb is linearized On Tue, Oct 26, 2010 at 12:28:01PM -0700, David Miller wrote: > From: Flavio Leitner <fleitner@...hat.com> > Date: Tue, 26 Oct 2010 17:25:11 -0200 > > > If I understand that correctly, the gso_segs is the number > > of GSO segments which are divided in non-linear way. When the > > copy is made using that function, the skb turns into a big > > one segment inlined. So, the idea of segments is lost and > > I'm not seeing how it is going to be divided again. > > Later the NIC drives does, for example: > > GSO has nothing to do with linearity, although it just so happens > to be that GSO packets tend to be non-linear due to the way > TCP builds such frames. > > The GSO segment count is the number of MSS sized frames are > contained inside of a larger than MSS sized SKB. > > That is it. So the definition and meaning is independent of > linearity. > > Thus, if we linearize a larger than MSS sized frame, it should still > have the same GSO attributes. It makes sense, thanks for the explanation. Please ignore the proposed patch. thanks again, -- Flavio -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists