netdev - Re: [RFC v2] ipvs: allow transmit of GRO aggregated skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101108141955.GA31649@gondor.apana.org.au>
Date:	Mon, 8 Nov 2010 22:19:55 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Simon Horman <simon@...ms.net>
Cc:	Julian Anastasov <ja@....bg>, lvs-devel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [RFC v2] ipvs: allow transmit of GRO aggregated skbs

On Mon, Nov 08, 2010 at 08:45:42PM +0900, Simon Horman wrote:
>
> > 	Yes, I think we should check for !skb_is_gso(skb)
> > as it looks as correct check to avoid FRAG_NEEDED after GRO
> > but lets wait for confirmation from Herbert Xu.
> 
> Yes, lets try and get a word from Herbert Xu on this.

Yes skb_is_gso(skb) is the best for now.  It isn't 100% correct
as we should still be checking that the gso_size is less than
the MTU but we need to fix that elsewhere first.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html