netdev - Re: [PATCH] iproute2: add VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101109142219.0166576a@nehalam>
Date:	Tue, 9 Nov 2010 14:22:19 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Roopa Prabhu <roprabhu@...co.com>
Cc:	netdev@...r.kernel.org, chrisw@...hat.com, scofeldm@...co.com,
	arnd@...db.de
Subject: Re: [PATCH] iproute2: add VF_PORT support

On Tue, 09 Nov 2010 14:20:11 -0800
Roopa Prabhu <roprabhu@...co.com> wrote:

> 			response == PORT_VDP_RESPONSE_SUCCESS ?
> +				"SUCCESS" :
> +			response == PORT_VDP_RESPONSE_INVALID_FORMAT ?
> +				"INVALID FORMAT" :
> +			response == PORT_VDP_RESPONSE_INSUFFICIENT_RESOURCES ?
> +				"INSUFFICIENT RESOURCES" :
> +			response == PORT_VDP_RESPONSE_UNUSED_VTID ?
> +				"UNUSED VTID" :
> +			response == PORT_VDP_RESPONSE_VTID_VIOLATION ?
> +				"VTID VIOLATION" :
> +			response == PORT_VDP_RESPONSE_VTID_VERSION_VIOALTION ?
> +				"VTID VERSION VIOLATION" :
> +			response == PORT_VDP_RESPONSE_OUT_OF_SYNC ?
> +				"OUT-OF-SYNC" :
> +			response == PORT_PROFILE_RESPONSE_SUCCESS ?
> +				"SUCCESS" :
> +			response == PORT_PROFILE_RESPONSE_INPROGRESS ?
> +				"IN-PROGRESS" :
> +			response == PORT_PROFILE_RESPONSE_INVALID ?
> +				"INVALID" :
> +			response == PORT_PROFILE_RESPONSE_BADSTATE ?
> +				"BAD STATE" :
> +			response == PORT_PROFILE_RESPONSE_INSUFFICIENT_RESOURCES ?
> +				"INSUFFICIENT RESOURCES" :
> +			response == PORT_PROFILE_RESPONSE_ERROR ?
> +				"ERROR" :
> +			"UNKNOWN RESPONSE");

That's an ugly way to do this.
Make it a real function nor array.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html