netdev - Re: Netlink limitations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1011100040220.7998@obet.zrqbmnf.qr>
Date:	Wed, 10 Nov 2010 00:42:25 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Thomas Graf <tgraf@...radead.org>
cc:	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>, pablo@...filter.org,
	netdev@...r.kernel.org
Subject: Re: Netlink limitations

On Wednesday 2010-11-10 00:35, Thomas Graf wrote:

>On Tue, Nov 09, 2010 at 11:02:30PM +0100, Jan Engelhardt wrote:
>> 
>> On Tuesday 2010-11-09 22:40, Thomas Graf wrote:
>> >The addition won't be a revolution but it the increased header size,
>> >8 vs. 12 bytes isn't a big deal and gives us some additional room to
>> >work with in the future.
>> >
>> >struct nlattr_ext {
>> >	u16	oldlen;		/* 0 */
>> >	u16	kind;		/* TCA_* */
>> >	u8	type;		/* NLA_U32 */
>> >	u8	flags;		/* NLA_F_* */
>> >	u16	reserved;
>> >	u32	length;
>> >};
>> 
>> And while we're discussing this, surely there are no objections
>> to bumping NLA_ALIGN to 8 at the same time..
>
>We can't do that. That would break _everything_.

Using nlattr_ext also breaks _something_, unless it's only used for new 
stuff. Similarly, a new NLA_EXT_ALIGN could be used with just those that 
also start using nlattr_ext.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html