[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 11 Nov 2010 17:56:58 +0100
From: Eric Dumazet <eric.dumazet@...il.com>
To: Ben Greear <greearb@...delatech.com>
Cc: netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] macvlan: lockless tx path
Le jeudi 11 novembre 2010 à 08:40 -0800, Ben Greear a écrit :
> So, they assume counters are exactly 32 or 64 bits.
> Your example of the 36-bit counter would break their
> assumptions of 32 or 64 bits.
>
They 'assume'. I am not. How do you handle counters that suddenly go to
0 ?
> I agree that you can guess if the counter is 32 or 64, at least with today's
> hardware and relatively normal poll times, and the requirement that the
> counters can ONLY be 32 or 64 bits. I still consider it a kludge to
> return 32 bit counters in stats64, however. Would you consider
> a patch to have netlink pay attention to whether the stats are 32 or
> 64 (based on a flag returned from dev_get_stats perhaps)?
So what ? How is it going to help /proc/net/dev users (most apps use it)
Could you please adapt your software, and not adapt linux to your
needs ? Dont your software runs on linux 2.6.32 ?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists