lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 11 Nov 2010 10:41:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org,
	rolandd@...co.com, sean.hefty@...el.com, hal.rosenstock@...il.com
Subject: Re: [PATCH net-next-2.6] net: get rid of rtable->idev

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 11 Nov 2010 18:14:07 +0100

> It seems idev field in struct rtable has no special purpose, but adding
> extra atomic ops.
> 
> We hold refcounts on the device itself (using percpu data, so pretty
> cheap in current kernel).
> 
> infiniband case is solved using dst.dev instead of idev->dev
> 
> Removal of this field means routing without route cache is now using
> shared data, percpu data, and only potential contention is a pair of
> atomic ops on struct neighbour per forwarded packet.
> 
> About 5% speedup on routing test.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Roland Dreier <rolandd@...co.com>
> Cc: Sean Hefty <sean.hefty@...el.com>
> Cc: Hal Rosenstock <hal.rosenstock@...il.com>

Yes, let's remove as much unused crap as possible :-)

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists