netdev - Re: [PATCH net-2.6 v2 3/3] ixgbe: Look inside vlan when determining offload protocol.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101112.122433.115917799.davem@davemloft.net>
Date:	Fri, 12 Nov 2010 12:24:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jesse@...ira.com
Cc:	netdev@...r.kernel.org, hzheng@...ira.com,
	jeffrey.t.kirsher@...el.com, alexander.h.duyck@...el.com,
	jesse.brandeburg@...el.com
Subject: Re: [PATCH net-2.6 v2 3/3] ixgbe: Look inside vlan when
 determining offload protocol.

From: Jesse Gross <jesse@...ira.com>
Date: Thu, 11 Nov 2010 15:47:59 -0800

> From: Hao Zheng <hzheng@...ira.com>
> 
> Currently the skb->protocol field is used to setup various
> offloading parameters on transmit for the correct protocol.
> However, if vlan offloading is disabled or otherwise not used,
> the protocol field will be ETH_P_8021Q, not the actual protocol.
> This will cause the offloading to be not performed correctly,
> even though the hardware is capable of looking inside vlan tags.
> Instead, look inside the header if necessary to determine the
> correct protocol type.
> 
> To some extent this fixes a regression from 2.6.36 because it
> was previously not possible to disable vlan offloading and this
> error case was not exposed.
> 
> Signed-off-by: Hao Zheng <hzheng@...ira.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> CC: Alex Duyck <alexander.h.duyck@...el.com>
> CC: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jesse Gross <jesse@...ira.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html