netdev - Re: [PATCH v2] Prevent crashing when parsing bad X.25 facilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101112.122946.102556009.davem@davemloft.net>
Date:	Fri, 12 Nov 2010 12:29:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	drosenberg@...curity.com
Cc:	andrew.hendry@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] Prevent crashing when parsing bad X.25 facilities

From: Dan Rosenberg <drosenberg@...curity.com>
Date: Fri, 12 Nov 2010 09:07:57 -0500

> @@ -149,9 +157,8 @@ int x25_parse_facilities(struct sk_buff *skb, struct x25_facilities *facilities,
>  				break;
>  			default:
>  				printk(KERN_DEBUG "X.25: unknown facility %02X,"
> -					"length %d, values %02X, %02X, "
> -					"%02X, %02X\n",
> -					p[0], p[1], p[2], p[3], p[4], p[5]);
> +					"length %d\n"
> +					p[0], p[1]);
>  				break;

Thanks for not even compile testing your changes:

net/x25/x25_facilities.c: In function 'x25_parse_facilities':
net/x25/x25_facilities.c:161:6: error: expected ')' before 'p'
net/x25/x25_facilities.c:161:6: warning: too few arguments for format

I find this kind of carelessness extremely amusing coming from someone
who is so big on security theatre.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html