netdev - Re: [PATCH] r8169: fix checksum broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101112.124401.35026128.davem@davemloft.net>
Date:	Fri, 12 Nov 2010 12:44:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shanwei@...fujitsu.com
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: fix checksum broken 

From: Shan Wei <shanwei@...fujitsu.com>
Date: Fri, 12 Nov 2010 18:15:25 +0800

> If r8196 received packets with invalid sctp/igmp(not tcp, udp) checksum, r8196 set skb->ip_summed
> wit CHECKSUM_UNNECESSARY. This cause that upper protocol don't check checksum field.
> 
> I am not family with r8196 driver. I try to guess the meaning of RxProtoIP and IPFail.
> RxProtoIP stands for received IPv4 packet that upper protocol is not tcp and udp. 
> !(opts1 & IPFail) is true means that driver correctly to check checksum in IPv4 header.
> 
> If it's right, I think we should not set ip_summed wit CHECKSUM_UNNECESSARY for my sctp packets
> with invalid checksum. 
> 
> If it's not right, please tell me. 
> 
> 
> Signed-off-by: Shan Wei <shanwei@...fujitsu.com>

Francois, please review, it looks correct to my eyes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html