| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <OF95BC4C89.14730D6A-ONC12577DB.005073FE-C12577DB.0050E5CE@transmode.se> Date: Sun, 14 Nov 2010 15:43:37 +0100 From: Joakim Tjernlund <joakim.tjernlund@...nsmode.se> To: Anton Vorontsov <cbouatmailru@...il.com> Cc: linuxppc-dev@...ts.ozlabs.org, netdev@...r.kernel.org Subject: Re: [PATCH 2/2] ucc_geth: Fix deadlock Anton Vorontsov <cbouatmailru@...il.com> wrote on 2010/11/12 15:09:47: > > On Fri, Nov 12, 2010 at 02:55:09PM +0100, Joakim Tjernlund wrote: > > This script: > > while [ 1==1 ] ; do ifconfig eth0 up; usleep 1950000 ;ifconfig eth0 down; dmesg -c ;done > > causes in just a second or two: > > INFO: task ifconfig:572 blocked for more than 120 seconds. > [...] > > The reason appears to be ucc_geth_stop meets adjust_link as the > > PHY reports PHY changes. I belive adjust_link hangs somewhere, > > holding the PHY lock, because ucc_geth_stop disabled the > > controller HW. > > Fix is to stop the PHY before disabling the controller. > > > > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se> > > It's unclear where exactly adjust_link() hangs, but the patch > looks as the right thing overall. Yes, I too cannot find where it is hanging, just that it is hanging somewhere. I am starting to think it is hanging somewhere else. Anyhow, the hang goes away 100% when this patch is applied. Jocke -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists