netdev - Re: [PATCH net-next-26 5/5] cxgb4vf: Mark "UDP [RSS Hash] Enable" as a 1-bit field.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201011150943.32541.leedom@chelsio.com>
Date:	Mon, 15 Nov 2010 09:43:32 -0800
From:	Casey Leedom <leedom@...lsio.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-26 5/5] cxgb4vf: Mark "UDP [RSS Hash] Enable" as a 1-bit field.

| From: David Miller <davem@...emloft.net>
| Date: Monday, November 15, 2010 09:20 am
| 
| From: Casey Leedom <leedom@...lsio.com>
| Date: Thu, 11 Nov 2010 11:30:44 -0800
| 
| > +		uint synmapen:1;	/* SYN Map Enable */
| 
| Please do not use the "uint" shorthand for "unsigned int", I know it's
| in linux/types.h but that is there for sysv compatibility in
| userspace and is ugly as hell.

  Okay, sorry about that.  I wasn't sure so I looked around and saw several 
other network device drivers using "uint" and figured it was okay.  I assume 
that it's okay to use u32, etc?  I was just trying to be neet and solve the 
"greater than 80 column" restriction which the patch check script complains 
about for when a previous changeset converted "int" to "unsigned int".  Just let 
me know what the correct action is and I'll respin this one patch.  Thanks for 
your patience with my ignorance!

Casey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html