netdev - vmxnet3 multiqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20101115.101649.245385009.davem@davemloft.net>
Date:	Mon, 15 Nov 2010 10:16:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhatewara@...are.com
CC:	netdev@...r.kernel.org
Subject: vmxnet3 multiqueue

Two things:

1) Do not quote the entire patch when asking for feedback,
   that adds needless scrolling for people trying to read
   through either the thread on an archive site or me trying
   to skim through the feedback in the patchwork entry.

   You are not adding any new information at all by quoting
   the entire patch, and in fact you are making it more difficult
   for the very people you want replies from.

2) You're still adding driver specific module option knobs
   which we have consistently stated are not to be added to
   any driver.  Instead create generic facilities that any
   driver, not just your's, can make use of.

For now I would simply rip out the module option knobs and
submit the simplest patch possible which always turns on
multiqueue and never acts conditionally.

You can add the knobs via a kernel wide facility later.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html