netdev - Re: [PATCH] net: use the macros defined for the members of flowi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1289857126.3364.14.camel@edumazet-laptop>
Date:	Mon, 15 Nov 2010 22:38:46 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Brian Haley <brian.haley@...com>
Cc:	Changli Gao <xiaosuo@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: use the macros defined for the members of flowi

Le lundi 15 novembre 2010 à 16:33 -0500, Brian Haley a écrit :
> On 11/12/2010 11:43 PM, Changli Gao wrote:
> > Use the macros defined for the members of flowi to clean the code up.
> > 
> > diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
> > index 865fd76..36cd0b7 100644
> > --- a/net/bridge/br_netfilter.c
> > +++ b/net/bridge/br_netfilter.c
> > @@ -412,13 +412,8 @@ static int br_nf_pre_routing_finish(struct sk_buff *skb)
> >  	if (dnat_took_place(skb)) {
> >  		if ((err = ip_route_input(skb, iph->daddr, iph->saddr, iph->tos, dev))) {
> >  			struct flowi fl = {
> > -				.nl_u = {
> > -					.ip4_u = {
> > -						 .daddr = iph->daddr,
> > -						 .saddr = 0,
> > -						 .tos = RT_TOS(iph->tos) },
> > -				},
> > -				.proto = 0,
> > +				.fl4_dst = iph->daddr,
> > +				.fl4_tos = RT_TOS(iph->tos),
> >  			};
> 
> Are these actually equivalent?  You dropped two assignments to zero.
> I always thought things on the stack weren't.

Same question on lkml few hours ago. I think gcc does the assignement to
zero, even on automatic variables (at least done on x86), but could not
find a doc on it.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html