netdev - Re: Integer overflow in RDS cmsg handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CE30A04.80609@oracle.com>
Date:	Tue, 16 Nov 2010 14:47:32 -0800
From:	Andy Grover <andy.grover@...cle.com>
To:	Dan Rosenberg <drosenberg@...curity.com>
CC:	netdev@...r.kernel.org, security@...nel.org
Subject: Re: Integer overflow in RDS cmsg handling

On 11/16/2010 01:09 PM, Dan Rosenberg wrote:
> In rds_cmsg_rdma_args(), the user-provided args->nr_local value is
> restricted to less than UINT_MAX.  This seems to need a tighter upper
> bound, since the calculation of total iov_size can overflow, resulting
> in a small sock_kmalloc() allocation.  This would probably just result
> in walking off the heap and crashing when calling rds_rdma_pages() with
> a high count value.  If it somehow doesn't crash here, then memory
> corruption could occur soon after.

UIO_MAXIOV (1024) instead of UINT_MAX seems preferable, yes?

Thanks -- Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html