netdev - Re: [net-2.6 PATCH] ipv6: fix missing in6_ifa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1289889454.3364.122.camel@edumazet-laptop>
Date:	Tue, 16 Nov 2010 07:37:34 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [net-2.6 PATCH] ipv6: fix missing in6_ifa_put in addrconf

Le lundi 15 novembre 2010 à 22:29 -0800, John Fastabend a écrit :
> Fix ref count bug introduced by
> 
> commit 2de795707294972f6c34bae9de713e502c431296
> Author: Lorenzo Colitti <lorenzo@...gle.com>
> Date:   Wed Oct 27 18:16:49 2010 +0000
> 
> ipv6: addrconf: don't remove address state on ifdown if the address
> is being kept
> 
> 
> Fix logic so that addrconf_ifdown() decrements the inet6_ifaddr
> refcnt correctly with in6_ifa_put().
> 
> Reported-by: Stephen Hemminger <shemminger@...tta.com>
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> ---
> 
>  net/ipv6/addrconf.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index b41ce0f..aaa3ca4 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2754,13 +2754,13 @@ static int addrconf_ifdown(struct net_device *dev, int how)
>  			ifa->state = INET6_IFADDR_STATE_DEAD;
>  			spin_unlock_bh(&ifa->state_lock);
>  
> -			if (state == INET6_IFADDR_STATE_DEAD) {
> -				in6_ifa_put(ifa);
> -			} else {
> +			if (state != INET6_IFADDR_STATE_DEAD) {
>  				__ipv6_ifa_notify(RTM_DELADDR, ifa);
>  				atomic_notifier_call_chain(&inet6addr_chain,
>  							   NETDEV_DOWN, ifa);
>  			}
> +
> +			in6_ifa_put(ifa);
>  			write_lock_bh(&idev->lock);
>  		}
>  	}
> 

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks again John


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html