netdev - Re: [PATCH net-next-2.6] bonding: IGMP handling cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101118.093330.39181120.davem@davemloft.net>
Date:	Thu, 18 Nov 2010 09:33:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	sachinp@...ibm.com, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-next@...r.kernel.org,
	ursula.braun@...ibm.com, fubar@...ibm.com
Subject: Re: [PATCH net-next-2.6] bonding: IGMP handling cleanup

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 18 Nov 2010 11:49:12 +0100

> Le jeudi 18 novembre 2010 à 11:26 +0100, Eric Dumazet a écrit :
> 
>> Actually this raises an interesting case for bonding as well.
>> 
>> Before my RCU conversion __bond_resend_igmp_join_requests() was unsafe.
>> 
>> For net-next-2.6, it is now safe (RCU is held), but needs a cleanup
>> patch to avoid sparse errors.
> 
> [PATCH net-next-2.6] bonding: IGMP handling cleanup
> 
> Instead of iterating in_dev->mc_list from bonding driver, its better
> to call a helper function provided by igmp.c
> Details of implementation (locking) are private to igmp code.
> 
> ip_mc_rejoin_group(struct ip_mc_list *im) becomes
> ip_mc_rejoin_groups(struct in_device *in_dev);
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Jay Vosburgh <fubar@...ibm.com>
> Cc: Sachin Sant <sachinp@...ibm.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html