netdev - Re: [PATCH] net: irda: irttp: sync error paths of data- and udata-requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101118.122451.191398084.davem@davemloft.net>
Date:	Thu, 18 Nov 2010 12:24:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	w.sang@...gutronix.de
Cc:	netdev@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: [PATCH] net: irda: irttp: sync error paths of data- and
 udata-requests

From: Wolfram Sang <w.sang@...gutronix.de>
Date: Tue, 16 Nov 2010 20:40:02 +0100

> irttp_data_request() returns meaningful errorcodes, while irttp_udata_request()
> just returns -1 in similar situations. Sync the two and the loglevels of the
> accompanying output.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: David Miller <davem@...emloft.net>
> ---
> 
> Thank you David for picking up the zero-byte-packet-patch. Now as it was
> applied, this one might be interesting, too (on top of it)? Nothing seriously
> needed, but looks more proper IMHO. LXR says that are callers of these
> functions check with < 0 anyhow.

Better error code reporting is always appreciated :-)

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html