netdev - Re: [PATCH 2.6.37-rc1] net-next: Add multiqueue support to vmxnet3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101119.123735.246535099.davem@davemloft.net>
Date:	Fri, 19 Nov 2010 12:37:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sbhatewara@...are.com
Cc:	bhutchings@...arflare.com, shemminger@...tta.com,
	netdev@...r.kernel.org, pv-drivers@...are.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.37-rc1] net-next: Add multiqueue support to vmxnet3
 driver

From: Shreyas Bhatewara <sbhatewara@...are.com>
Date: Fri, 19 Nov 2010 10:46:59 -0800 (PST)

> 
> From: Shreyas Bhatewara <sbhatewara@...are.com>
> 
> Add multiqueue support to vmxnet3 driver
> 
> This change adds multiqueue and thus receive side scaling support
> to vmxnet3 device driver. Number of rx queues is limited to 1 in cases
> where MSI is not configured or one MSIx vector is not available per rx 
> queue
> 
> Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>
> Reviewed-by: Bhavesh Davda <bhavesh@...are.com>

Your patch is corrupted:

> @@ -107,7 +110,7 @@ static void
>  vmxnet3_tq_start(struct vmxnet3_tx_queue *tq, struct vmxnet3_adapter *adapter)
>  {
>  	tq->stopped = false;
> -	netif_start_queue(adapter->netdev);
> +	netif_start_subqueue(adapter->netdev, tq - adapter->tx_queue);
>  }
>  
>  

This hunk has an incorrect header, the hunk header states that
both before and after the change there should be 7 lines in the
code block, but there are 8.

One way this can happen is if you edit the patch in emacs since
it has a patch editing mode which kicks which tries to "fix up"
the hunk headers, but most of the time it actually corrupts them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html