netdev - Re: [PATCH net-2.6] atl1c: Fix hardware type check for enabling OTP CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101121.100759.59702930.davem@davemloft.net>
Date:	Sun, 21 Nov 2010 10:07:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	lrodriguez@...eros.com, Jie.Yang@...eros.com,
	linux-team@...eros.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] atl1c: Fix hardware type check for enabling
 OTP CLK

From: Ben Hutchings <ben@...adent.org.uk>
Date: Sat, 20 Nov 2010 04:55:36 +0000

> Commit 496c185c9495629ef1c65387cb2594578393cfe0 "atl1c: Add support
> for Atheros AR8152 and AR8152" added the condition:
> 
>              if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b)
> 
> for enabling OTP CLK, and the condition:
> 
>              if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c)
> 
> for disabling OTP CLK.  Since the two previously defined hardware
> types are athr_l1c and athr_l2c, the latter condition appears to be
> the correct one.  Change the former to match.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
> This is compile-tested only.  It looks like the current code may fail to
> read non-volatile settings on the L2C hardware since the EEPROM will not
> be clocked.  Please check this.

This was brought up before, perhaps 4 or 5 months ago, and the maintainers
for this driver just fooled around and never brought this issue to a
meaningful resolution.

So I'm just going to apply your patch instead of waiting another half
year for something to happen.

Thanks Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html