netdev - Re: [PATCH 1/2] usbnet: changes for upcoming cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290538720.2529.109.camel@helium>
Date:	Tue, 23 Nov 2010 10:58:40 -0800
From:	David Brownell <david-b@...bell.net>
To:	Alexey Orishko <alexey.orishko@...il.com>
Cc:	gregkh@...e.de, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	oliver@...kum.org, yauheni.kaliuta@...ia.com,
	felipe.balbi@...ia.com, sjur.brandeland@...ricsson.com,
	Alexey Orishko <alexey.orishko@...ricsson.com>
Subject: Re: [PATCH 1/2] usbnet: changes for upcoming cdc_ncm driver

On Tue, 2010-11-23 at 17:51 +0100, Alexey Orishko wrote:

> -		skb_queue_tail (&dev->done, skb);
> +	if (skb->len) {
> +		/* all data was already cloned inside NCM driver */

Fix this comment.  NCM isn't the only framing policy which un-batches
RX packets ... RNDIS has done so for a number of years already, and
more recently EEM needs it too ... plus at least one hardware driver.

Also, check pending patches, since I seem to recall one that supports
some hardware (SMSC?) that batches, and needed to update the calling
convention you're using here (i.e. the original one).


> +		if (dev->driver_info->flags & FLAG_MULTI_PACKET)

except ... you documented this flag as affecting TX paths not RX...
> +			dev_kfree_skb_any(skb);
> +		else
> +			usbnet_skb_return(dev, skb);
> +		return;
>  	}
> +
> +	netif_dbg(dev, rx_err, dev->net, "drop\n");
> +error:
> +	dev->net->stats.rx_errors++;
> +	skb_queue_tail(&dev->done, skb);
>  }
>  


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html