netdev - Re: [PATCHv2] hso: fix disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290700866.2112.60.camel@filip-linux>
Date:	Thu, 25 Nov 2010 17:01:06 +0100
From:	Filip Aben <f.aben@...ion.com>
To:	Johan Hovold <jhovold@...il.com>
Cc:	davem@...emloft.net, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, pki@...com.pl
Subject: Re: [PATCHv2] hso: fix disable_net

On Thu, 2010-11-25 at 16:03 +0100, Johan Hovold wrote:
> On Thu, Nov 25, 2010 at 2:40 PM, Filip Aben <f.aben@...ion.com> wrote:
> > The HSO driver incorrectly creates a serial device instead of a net
> > device when disable_net is set. It shouldn't create anything for the
> > network interface.
> >
> > Signed-off-by: Filip Aben <f.aben@...ion.com>
> 
> Please add the appropriate Reported-by-tags as well, e.g.
> 
> Reported-by: Piotr Isajew <pki@...com.pl>
> Reported-by: Johan Hovold <jhovold@...il.com>

I would have gladly done so if you included that in your comment on the
previous patch :)

> 
> As this patch is meant to fix a driver crash, perhaps it should be marked for
> stable as well?
> 

I don't think it's that critical: it only applies to people explicitly
loading the module with disable_net set. But feel free to queue it up
for stable.

Thanks,

Filip-



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html