lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1290763798-22844-1-git-send-email-leoli@freescale.com> Date: Fri, 26 Nov 2010 17:29:58 +0800 From: Li Yang <leoli@...escale.com> To: <linuxppc-dev@...ts.ozlabs.org>, <netdev@...r.kernel.org>, <davem@...emloft.net> CC: Li Yang <leoli@...escale.com>, Jean-Denis Boyer <jdboyer@...ia5corp.com>, Andreas Schmitz <Andreas.Schmitz@...del.net>, Anton Vorontsov <avorontsov@...mvista.com> Subject: [PATCH] ucc_geth: fix ucc halt problem in half duplex mode In commit 58933c64(ucc_geth: Fix the wrong the Rx/Tx FIFO size), the UCC_GETH_UTFTT_INIT is set to 512 based on the recommendation of the QE Reference Manual. But that will sometimes cause tx halt while working in half duplex mode. According to errata draft QE_GENERAL-A003(High Tx Virtual FIFO threshold size can cause UCC to halt), setting UTFTT less than [(UTFS x (M - 8)/M) - 128] will prevent this from happening (M is the minimum buffer size). The patch changes UTFTT back to 256. Signed-off-by: Li Yang <leoli@...escale.com> Cc: Jean-Denis Boyer <jdboyer@...ia5corp.com> Cc: Andreas Schmitz <Andreas.Schmitz@...del.net> Cc: Anton Vorontsov <avorontsov@...mvista.com> --- drivers/net/ucc_geth.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth.h b/drivers/net/ucc_geth.h index 05a9558..a78b9c0 100644 --- a/drivers/net/ucc_geth.h +++ b/drivers/net/ucc_geth.h @@ -899,7 +899,8 @@ struct ucc_geth_hardware_statistics { #define UCC_GETH_UTFS_INIT 512 /* Tx virtual FIFO size */ #define UCC_GETH_UTFET_INIT 256 /* 1/2 utfs */ -#define UCC_GETH_UTFTT_INIT 512 +#define UCC_GETH_UTFTT_INIT 256 /* 1/2 utfs + due to errata */ /* Gigabit Ethernet (1000 Mbps) */ #define UCC_GETH_URFS_GIGA_INIT 4096/*2048*/ /* Rx virtual FIFO size */ -- 1.6.6-rc1.GIT -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists