netdev - Re: [PATCH] ehea: Add some info messages and fix an issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Nov 2010 09:01:48 -0800
From:	Joe Perches <joe@...ches.com>
To:	leitao@...ux.vnet.ibm.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ehea: Add some info messages and fix an issue

On Fri, 2010-11-26 at 14:26 -0200, leitao@...ux.vnet.ibm.com wrote:
> This patch adds some debug information about ehea not being able to
> allocate enough spaces. Also it correctly updates the amount of available
> skb.

This patch introduces unnecessary whitespace into the logging messages.

> Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>
[]
> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
[]
> @@ -400,6 +400,8 @@ static void ehea_refill_rq1(struct ehea_port_res *pr, int index, int nr_of_wqes)
>  			skb_arr_rq1[index] = netdev_alloc_skb(dev,
>  							      EHEA_L_PKT_SIZE);
>  			if (!skb_arr_rq1[index]) {
> +				ehea_info("Unable to allocate enough skb in
> +					   the array\n");

Don't split up the message into multiple lines like this.
Either just use a single line like:

				ehea_info("Unable to allocate enough skb in the array\n");

and ignore 80 column line lengths, or break up the line into
quoted parts:

				ehea_info("Unable to allocate enough skb in"
					  "the array\n");

The first option is preferred to make grepping easier.

[]

> @@ -735,8 +744,11 @@ static int ehea_proc_rwqes(struct net_device *dev,
>  
>  					skb = netdev_alloc_skb(dev,
>  							       EHEA_L_PKT_SIZE);
> -					if (!skb)
> +					if (!skb) {
> +						ehea_info("Not enough memory to
> +							   allocate skb\n");

here too


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html