lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 27 Nov 2010 17:44:04 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux1394-devel <linux1394-devel@...ts.sourceforge.net>
Subject: Re: [Q] How to invalidate ARP cache for a network device from
 within kernel

On Sat, 2010-11-27 at 16:19 +0100, Stefan Richter wrote:
> On Nov 27 Stefan Richter wrote:
> > > @@ -1593,10 +1593,15 @@ static void fwnet_update(struct fw_unit
> > > *unit) {
> > >  	struct fw_device *device = fw_parent_device(unit);
> > >  	struct fwnet_peer *peer = dev_get_drvdata(&unit->device);
> > > +	struct fwnet_device *dev = peer->dev;
> > >  	int generation;
> > >  
> > >  	generation = device->generation;
> > >  
> > > +	fw_iso_context_stop(dev->broadcast_rcv_context);
> > > +	fw_iso_context_start(dev->broadcast_rcv_context, -1, 0,
> > > +			FW_ISO_CONTEXT_MATCH_ALL_TAGS);
> [...]
> > OTOH, is this actually necessary on normal bus resets?  It should only
> > be necessary after PM resume, right?  If so, perhaps do it only if the
> > generation increased by more than one.
> 
> Actually, shouldn't context restart at resume happen in firewire-ohci
> rather?  Any other protocol driver which uses isochronous I/O (be it a
> kernel driver or userspace driver) would have the same issue, I guess.
Well, the spec says that upon bus reset ISO channels must be allocated
again.
This somewhat mimics that, although it can be done better.

Of course the same true after suspend/resume.

Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists