netdev - Re: [PATCH 5/6] forcedeth: use KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290884641.3292.0.camel@localhost>
Date:	Sat, 27 Nov 2010 19:04:01 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Szymon Janc <szymon@...c.net.pl>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/6] forcedeth: use KERN_ facility level in printk

On Sat, 2010-11-27 at 19:39 +0100, Szymon Janc wrote:
> Signed-off-by: Szymon Janc <szymon@...c.net.pl>
> ---
>  drivers/net/forcedeth.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index 2f092d7..a2b6681 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -958,7 +958,7 @@ static int reg_delay(struct net_device *dev, int offset, u32 mask, u32 target,
>  		delaymax -= delay;
>  		if (delaymax < 0) {
>  			if (msg)
> -				printk("%s", msg);
> +				printk(KERN_WARNING "%s", msg);

No, msg already includes a log level.

Ben.

>  			return 1;
>  		}
>  	} while ((readl(base + offset) & mask) != target);

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html