netdev - Re: [PATCH net-next] bnx2x: Use skb_is_gso_v6(skb) instead of accessing the skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290939734.21703.78.camel@lb-tlvb-vladz>
Date:	Sun, 28 Nov 2010 12:22:14 +0200
From:	"Vladislav Zolotarov" <vladz@...adcom.com>
To:	"Eric Dumazet" <eric.dumazet@...il.com>
cc:	"Dave Miller" <davem@...emloft.net>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"netdev list" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bnx2x: Use skb_is_gso_v6(skb) instead of
 accessing the skb_shinfo(skb) directly


> 
> May I ask why ?
> 
> This seems not consistent with the previous block.
> 
> Either you also add a skb_is_gso_v4(skb) helper, or let the code as is,
> maybe reordering the flags ?
> 

U r right. I'm respinning a patch taking your remarks and a "brackets"
patch into an account.

thanks, Eric.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html