netdev - Re: [PATCH net-next-2.6 06/19 v5] can: EG20T PCH: Fix endianness issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <003c01cb8f5b$0f13e8b0$66f8800a@maildom.okisemi.com>
Date:	Mon, 29 Nov 2010 09:19:13 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"Marc Kleine-Budde" <mkl@...gutronix.de>
Cc:	"Wolfgang Grandegger" <wg@...ndegger.com>,
	"Wolfram Sang" <w.sang@...gutronix.de>,
	"Christian Pellegrin" <chripell@...e.org>,
	"Barry Song" <21cnbao@...il.com>,
	"Samuel Ortiz" <sameo@...ux.intel.com>,
	<socketcan-core@...ts.berlios.de>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	<andrew.chih.howe.khor@...el.com>, <qi.wang@...el.com>,
	<margie.foster@...el.com>, <yong.y.wang@...el.com>,
	<kok.howg.ewe@...el.com>, <joel.clark@...el.com>
Subject: Re: [PATCH net-next-2.6 06/19 v5] can: EG20T PCH: Fix endianness issue

On Friday, November 26, 2010 6:52 PM, Marc Kleine-Budde wrote :

> In an OOM situation the system is under pressure anyway. On low end
> systems it not good to print a message to the log. AFAICS no other can
> driver does this.

Does the above mean it doesn't have to process for returned value of
pch_can_rx_msg_lost  like below?
> +   pch_can_rx_msg_lost(ndev, obj_num);
> +   rcv_pkts++;
> +   quota--;

> AFAICS no other can driver does this.
I can see ti_hecc.c calls dev_err when alloc_can_err_skb fails.

Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html