| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Nov 2010 12:32:53 +0200 From: Vlad Lungu <vlad.lungu@...driver.com> To: Peppe CAVALLARO <peppe.cavallaro@...com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH] stmmac: fix stmmac_resume removing not yet used shutdown flag Peppe CAVALLARO wrote: > On 11/26/2010 3:11 PM, Peppe CAVALLARO wrote: >> The commit to convert to use the dev_pm_ops struct >> introduces a bug. The shutdown flag is not yet used >> because the hibernation on memory is done by using >> the freeze callback. >> Thanks to Vlad for having reported it. > Hi Vlad, > as we discussed via email, I'll also look at how to manage the > patch that reworked the private structure and that's generating > problems on your HW (I'll also try to have it for testing!). > Actually, this is is not a blocking problem. I can kmalloc a platform info structure and fill it with the relevant data on probe. It just feels ... wrong. The way I see it, the platform info is similar to the PNP on an ISA bus or the PCI header of a device. Having platform info for a PCI device is kind of a hack. You didn't know that there's a PCI device out there and that someone wants to submit a patch for it, so it probably made sense at the time to rework the structure that particular way. Regards, Vlad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists