netdev - Re: [PATCH] ehea: Use the standard logging functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CF52E7C.7010308@linux.vnet.ibm.com>
Date:	Tue, 30 Nov 2010 15:03:56 -0200
From:	Breno Leitao <leitao@...ux.vnet.ibm.com>
To:	Joe Perches <joe@...ches.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] ehea: Use the standard logging functions

Joe,

Thanks for the patch. Please make sure that it applies over the last 
Davem's tree. He just committed one patch that will probably conflict 
with this patch.

Also, this patch is printing:

ibmebus port0: foobarmessage

Instead of

ehea: foobarmessage

But this is a driver issue, and your patch just exposed this problem. I 
will send a patch for this soon.

Thanks
Breno

On 11/26/2010 09:27 PM, Joe Perches wrote:
> Remove ehea_error, ehea_info and ehea_debug macros.
> Use pr_fmt, pr_<level>, netdev_<level>  and netif_<level>  as appropriate.
> Fix messages to use trailing "\n", some messages had an extra one
> as the old ehea_<level>  macros added a trailing "\n".
> Coalesced long format strings.
>
> Uncompiled/untested.
>
> Signed-off-by: Joe Perches<joe@...ches.com>
Acked-by: Breno Leitao <leitao@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html