netdev - RE: [PATCH 1/2] ixgb: Don't check for vlan group on transmit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EA929A9653AAE14F841771FB1DE5A13660288B58E9@rrsmsx501.amr.corp.intel.com>
Date:	Tue, 30 Nov 2010 15:52:20 -0700
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	Jesse Gross <jesse@...ira.com>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: RE: [PATCH 1/2] ixgb: Don't check for vlan group on transmit.

Jesse Gross wrote:
> On Mon, Nov 8, 2010 at 11:59 AM, Jesse Gross <jesse@...ira.com> wrote:
>> On Fri, Nov 5, 2010 at 3:30 PM, Duyck, Alexander H
>>> The quick fix for your patch is to move the addition of
>>> VLAN_TAG_SIZE to the max_frame in igb_change_mtu instead of in the
>>> set_rlpml call.  Otherwise I will see about submitting an updated
>>> patch in the next few days.   
>> 
>> I happy to let you take care of it - obviously you know the
>> driver/hardware much better than I.
> 
> Alex, did you get a chance to take a look at this?  I was hoping to
> get the fix for this (and also the patch mentioned originally in this
> message for ixgb) into 2.6.37.  I can also respin it along the lines
> that you suggested if that would help.

Jesse, I am still looking at the ixgb patch. I think the patch is 
incomplete.

Simply removing the adapter->vlgrp check is not enough. According to 
the specs CTRL0_VME needs to be set in order for the vlan tag insertion/stripping to be enabled. We have a modified patch currently 
in test and will post it to netdev as soon as we confirm that it works 
as expected.

Thanks,
Emil--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html