netdev - Re: [PATCH v2] net: avoid the unnecessary kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1291105009.2725.48.camel@edumazet-laptop>
Date:	Tue, 30 Nov 2010 09:16:49 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: avoid the unnecessary kmalloc

Le mardi 30 novembre 2010 à 15:45 +0800, Changli Gao a écrit :

> I don't think it is a good idea, If it is, why not use
> ksize(skb->head) to set the tail pointer of skb when allocating a new
> skb.
> 

Calling ksize() for all allocated skb would be overkill, since most of
them are correctly sized and dont need expand() at all.

In what situation do you notice this being expand_head() ever called ?

> If we do sth. like this, more cache lines maybe involved.
> 

This has same number of _touched_ cache lines actually, and this is what
matters.

Actually I dont have strong feeling, this is a detail.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html