netdev - Re: [PATCH 2/3] net: snmp: fix the wrong ICMP_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101201.123658.242128686.davem@davemloft.net>
Date:	Wed, 01 Dec 2010 12:36:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shanwei@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] net: snmp: fix the wrong ICMP_MIB_MAX value

From: David Miller <davem@...emloft.net>
Date: Wed, 01 Dec 2010 12:35:50 -0800 (PST)

> From: Shan Wei <shanwei@...fujitsu.com>
> Date: Mon, 29 Nov 2010 14:53:55 +0800
> 
>> @@ -60,8 +60,7 @@ struct ipstats_mib {
>>  };
>>  
>>  /* ICMP */
>> -#define ICMP_MIB_MAX	(__ICMP_MIB_MAX + 1)
>> -
>> +#define ICMP_MIB_MAX	__ICMP_MIB_MAX
>>  struct icmp_mib {
> 
> In all of my trees there is an "ICMP_MIB_DUMMY" define here, and it's
> been there forever, I have no idea what you are patching against.

Nevermind I see that this depends upon your first patch.

Please resubmit all 3 patches once you've addressed the
feedback for patch #1.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html