netdev - Re: [PATCH net-next-2.6 v6 06/20] can: EG20T PCH: Fix endianness issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101202.131728.245392719.davem@davemloft.net>
Date:	Thu, 02 Dec 2010 13:17:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tomoya-linux@....okisemi.com
Cc:	wg@...ndegger.com, w.sang@...gutronix.de, chripell@...e.org,
	21cnbao@...il.com, sameo@...ux.intel.com,
	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, andrew.chih.howe.khor@...el.com,
	joel.clark@...el.com, kok.howg.ewe@...el.com,
	margie.foster@...el.com
Subject: Re: [PATCH net-next-2.6 v6 06/20] can: EG20T PCH: Fix endianness
 issue

From: David Miller <davem@...emloft.net>
Date: Thu, 02 Dec 2010 13:15:51 -0800 (PST)

> 
> This patch and the rest I cannot apply because they have
> dependencies upon patch #4 which I've stated is not
> implemented correctly.

Also please make sure that you add proper CONFIG_PM checks to your
driver in order to fix these warnings:

drivers/net/can/pch_can.c:249:13: warning: 'pch_can_set_int_custom' defined but not used
drivers/net/can/pch_can.c:260:13: warning: 'pch_can_get_int_enables' defined but not used
drivers/net/can/pch_can.c:363:12: warning: 'pch_can_get_rxtx_ir' defined but not used
drivers/net/can/pch_can.c:393:13: warning: 'pch_can_set_rx_buffer_link' defined but not used
drivers/net/can/pch_can.c:413:13: warning: 'pch_can_get_rx_buffer_link' defined but not used

Thanks.
d
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html