netdev - Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 Dec 2010 07:16:42 -0800
From:	Greg KH <gregkh@...e.de>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Greg KH <greg@...ah.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	erazor_de@...rs.sourceforge.net,
	Randy Dunlap <rdunlap@...otime.net>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma
 usage in driver headers

On Thu, Dec 02, 2010 at 04:04:35PM +0100, Jiri Kosina wrote:
> On Tue, 30 Nov 2010, Greg KH wrote:
> 
> > > > Using pack pragma to prevent padding bytes in binary data structures
> > > > used for hardware communication. Explanation of these pragmas was requested.
> > > [...]
> > > 
> > > It would be clearer to use the '__packed' macro after each structure
> > > definition instead of using this awful Microsoft extension.
> > 
> > I agree, that's the "normal" Linux way of doing things.
> > 
> > Other than that, this patch set looks good to me.  Jiri, if the packed
> > change is made, do you want me to take these through my tree, or do you
> > want to take them through yours?  Whatever is easier for you is fine
> > with me.
> 
> Hi Greg,
> 
> as this is part of larger roccat patchset, I will be processing it through 
> my tree once completely reviewed.

Great, feel free to add my:
	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
to the driver core changes.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html