netdev - Re: [PATCH v3] net: don't reallocate skb->head unless the current one hasn't the needed extra size or is shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1291399299.2897.572.camel@edumazet-laptop>
Date:	Fri, 03 Dec 2010 19:01:39 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	xiaosuo@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: don't reallocate skb->head unless the current
 one hasn't the needed extra size or is shared

Le vendredi 03 décembre 2010 à 09:47 -0800, David Miller a écrit :
> From: Changli Gao <xiaosuo@...il.com>
> Date: Tue, 30 Nov 2010 16:48:46 +0800
> 
> > skb head being allocated by kmalloc(), it might be larger than what
> > actually requested because of discrete kmem caches sizes. Before
> > reallocating a new skb head, check if the current one has the needed
> > extra size.
> > 
> > Do this check only if skb head is not shared.
> > 
> > Signed-off-by: Changli Gao <xiaosuo@...il.com>
> > Cc: Eric Dumazet <eric.dumazet@...il.com>
> 
> Eric, ACK?

Yes :)

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html