lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 4 Dec 2010 23:07:22 +0800 From: Changli Gao <xiaosuo@...il.com> To: hadi@...erus.ca Cc: netdev@...r.kernel.org Subject: Re: [PATCH 3/3] ifb: move tq from ifb_private On Sat, Dec 4, 2010 at 10:59 PM, jamal <hadi@...erus.ca> wrote: > On Sat, 2010-12-04 at 22:50 +0800, Changli Gao wrote: > >> Maybe you misread my patch. tq is a stack variable in ri_tasklet, and >> initialized all the time. ri_tasklet() won't exits until tq is >> empty(). > > in your patch is a variable on the stack. > What i am saying is you should defer processing when there is an > error (note the two other spots i mentioned). > This means you may leave dp->tq non-empty and therefore it > needs to be saved somewhere as it is before your patch. > I know what you concern now. Thanks. I'll keep the old behavior in v2. -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists