netdev - Re: [PATCH] tcp: Replace time wait bucket msg by counter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1291499568.2806.100.camel@edumazet-laptop>
Date:	Sat, 04 Dec 2010 22:52:48 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: Replace time wait bucket msg by counter.

Le samedi 04 décembre 2010 à 13:35 -0800, Tom Herbert a écrit :
> Rather than printing the message to the log, use a mib counter to keep
> track of the count of occurences of time wait bucket overflow.  Reduces
> spam in logs.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---

>  
> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
> index 43cf901..3052a2b 100644
> --- a/net/ipv4/tcp_minisocks.c
> +++ b/net/ipv4/tcp_minisocks.c
> @@ -347,7 +347,7 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
>  		 * socket up.  We've got bigger problems than
>  		 * non-graceful socket closings.
>  		 */
> -		LIMIT_NETDEBUG(KERN_INFO "TCP: time wait bucket table overflow\n");
> +		NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPTIMEWAITOVERFLOW);
>  	}
>  
>  	tcp_update_metrics(sk);

NET_INC_STATS_BH() should be more appropriate, since we are in a
softirq ?





--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html