netdev - Re: [PATCH] ehea: add the correct LRO status at dev->features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101206084824.637d6b29@nehalam>
Date:	Mon, 6 Dec 2010 08:48:24 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	leitao@...ux.vnet.ibm.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ehea: add the correct LRO status at dev->features

On Mon,  6 Dec 2010 14:39:42 -0200
leitao@...ux.vnet.ibm.com wrote:

> Currently ehea is not setting NETIF_F_LRO, and it is not providing
> a callback for get_flags on ethtool. This patch fixes it.
> 
> Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>

More importantly, ehea does not support set_flags to disable LRO.

I will be more blunt. Any device that supports LRO and does
not have the necessary interface to disable it is broken and should
not be used.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html