| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101206181127.GB883@vigoh> Date: Mon, 6 Dec 2010 16:11:27 -0200 From: "Gustavo F. Padovan" <padovan@...fusion.mobi> To: Joe Perches <joe@...ches.com> Cc: Marcel Holtmann <marcel@...tmann.org>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 1/2] vsprintf: Add %pMbt, bluetooth mac address Hi Joe, * Joe Perches <joe@...ches.com> [2010-12-03 18:33:03 -0800]: > Bluetooth output the MAC address in reverse order. > Bluetooth memory order: 00 01 02 03 04 05 is output "05:04:03:02:01:00". > > This can save overall text when bluetooth is compiled in. > > Bluetooth currently uses a very slightly unsafe local function (batostr) > to output these formatted addresses. > > Adding %pMbt allows the batostr function to be removed. > > For x86: > > $ size lib/vsprintf*.o* > text data bss dec hex filename > 8189 0 2 8191 1fff lib/vsprintf.o.defconfig.new > 8150 0 2 8152 1fd8 lib/vsprintf.o.defconfig.old > 18633 56 3936 22625 5861 lib/vsprintf.o.allyesconfig.new > 18571 56 3920 22547 5813 lib/vsprintf.o.allyesconfig.old > > Signed-off-by: Joe Perches <joe@...ches.com> Looks good to me. Acked-by: Gustavo F. Padovan <padovan@...fusion.mobi> -- Gustavo F. Padovan http://profusion.mobi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists